> It looks like you're using _worth_saving_limit as both a method and a variable
> on similar classes, which is at least potentially confusing if not actually
> buggy....
lifeless: poolie: the last one I read looked like it could cause confusion about the internal state; jam's comments were along those lines and I agreed.
lifeless: I don't know if its been improved since then; and while its a functional improvement it is a risky area of code.
Combined with my comments I think this may need to be resubmitted.
> It looks like you're using _worth_saving_limit as both a method and a variable
> on similar classes, which is at least potentially confusing if not actually
> buggy....
lifeless: poolie: the last one I read looked like it could cause confusion about the internal state; jam's comments were along those lines and I agreed.
lifeless: I don't know if its been improved since then; and while its a functional improvement it is a risky area of code.
Combined with my comments I think this may need to be resubmitted.