Code review comment for lp:~ian-clatworthy/bzr/faster-dirstate-saving

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Ian Clatworthy wrote:
> I was happy to take this out of the queue while we focussed on 2.0. Right now though, I'm pretty confused here as to why this is rejected. Can someone do a proper review please and tell me exactly what's wrong?
>
> To my understanding, I addressed the first round of comments. If I need to rename a variable or method, that's approve-after-tweak, not reject surely.
>

To clarify

I was cleaning up the queue a bit, where we had lots of stuff marked one
way or another in votes, but not in the actual merge status. The last
statement on this was "I'll Reject for now" from Martin, but he had not
actually set the status, so I did.

My understanding was that this was meant to be, please address some of
the issues and resubmit.

Unfortunately, there is no "Resubmit" object for a merge proposal.
Potentially we could have used "Work in Progress", which I think takes
it out of the queue.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkrMmCsACgkQJdeBCYSNAANeAQCdFxROuxDkVbQ233ixrF+13CMK
mugAoLMztcg7TTwuLvEx3HS5VfgidKks
=wbea
-----END PGP SIGNATURE-----