> This patch fixes revert on trees with content filters. I've split this bit out
> from an earlier, more complex patch. This version explains the small code
> change in a bit more detail and adds a test for reverting a rename in addition
> to the one previously proposed (reverting a delete).
This seems like a correctness improvement but also a bit kludgey. Maybe we should merge it now but look to clean it up later.
Storing the content filters in a class-wide variable seems very strange.
Surely there should be some object that takes care of doing filtering if appropriate, rather than this being inline within tt?
> This patch fixes revert on trees with content filters. I've split this bit out
> from an earlier, more complex patch. This version explains the small code
> change in a bit more detail and adds a test for reverting a rename in addition
> to the one previously proposed (reverting a delete).
This seems like a correctness improvement but also a bit kludgey. Maybe we should merge it now but look to clean it up later.
Storing the content filters in a class-wide variable seems very strange.
Surely there should be some object that takes care of doing filtering if appropriate, rather than this being inline within tt?