Code review comment for lp:~intellectronica/launchpad/bugmail-ui-fixes

> This branch makes the menu link for subscribing to bug mail sensitive to the
> user's existing subsription. If the user is already subscribed (directly, or
> via one of the teams he's a member of), the link displays the edit icon and
> offers to edit subscription. If no subscription exists the link offers to
> subscribe and displays the add icon.

Nice change Tom! That'll make it much easier for people to follow when they want to edit or remove subscriptions. I actually had to revert your changes to see what happens currently because what you've done is so natural.

Two things on that page that are unrelated to your change, but might be nice to look at, here's a screenshot to show them:

http://people.canonical.com/~michaeln/tmp/bug-subscription-empty-portlet.png

1. There seems to be an empty portlet below? It looks like some ajax is meant to load something there - I'm guessing you're already aware and there's probably already a bug about it.

2. Is there any reason why the "Bug tracker: Launchpad, Bug supervisor:...." section is sitting over on the right like that? It looks exactly like the type of info that is usually a main-area portlet with an h2 heading and a dl (like the Project information at https://edge.launchpad.net/firefox ). Let me know what you think.

[snip]

>
> While working on this I realised that the form for editing structural
> subscriptions does not behave in the expected way, like all other boomerang
> forms. It doesn't offer a cancel link, and after submitting it displays the
> form again, instead of returning to the context. I plan to fix that in a
> future branch.

Great - A few other things to consider on that page when you get to it (in case you didn't already notice them).

First, the heading/breadcrumbs are currently:

Subscribe to Bugs in Jokosher Audio Editor
Jokosher >> Bugs >> Subscribe to Bugs in Jokosher Audio E...

My preference here would be for:

Subscribe to Bugs in Jokosher Audio Editor
Jokosher >> Bugs >> Subscribe

but I've sent an email out to the dev list about this yesterday, and it seems that the consensus is for:

Subscribe
Jokosher >> Bugs >> Subscribe

If you think that ^^ would be wrong, please voice your opinion on the email list :)

Secondly, that tip about "Managing Launchpad Bugs e-mail really doesn't belong there in the side-bar?

Anyway, they're unrelated to this branch. Great work!