Code review comment for lp:~ipython-dev/ipython/set_trace

> A few comments:
>
> * for 0.11, the actual embed implementation should go into ipapi or shell,
> which ever makes most sense. shell is now very cleaned up and it really
> only has things that qualify as being "public". Thus, it might make sense
> for it to go there.
> * There should definitely be an import of embed into IPython.__init__.
> Things like this shield users (at some level) from changes to the
> implementation of things.
> * The first time embed gets called it should create the IPShellEmbedded
> instance and *save* it as some global like, shell._embedded_shell (this
> makes me think ipapi makes more sense!) and then call it. Future calls to
> embed should just call the same instance over again. I want to make sure
> that embed can be called multiple times.
> * Trunk will be ready for this as of Friday this week.

Cool, please ping me when your branch is ready, so that I can take it and update the embed() code according to this thread.

Ondrej