Code review comment for lp:~jameinel/bzr/1.18-switch-branch

Revision history for this message
John A Meinel (jameinel) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Collins wrote:
> I should add, my suggestion will make this _much_ better for folk with
> lightweight checkouts away from the branch. Rather
> than ../../../../path/to/new-branch, they can use 'new-branch'.
>
> -Rob
>

I'm not sure if you noticed that I already check: "if '/' in to_location".

I'm not sure what more than that you need. (I even added tests for this
case....)

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkpXRZwACgkQJdeBCYSNAANMcACgjSDNhh14oqr3NV3lD5FMy9do
5xIAnjReCxMvAkIe38FGyQKga6Dm/foZ
=ugdy
-----END PGP SIGNATURE-----

« Back to merge proposal