Code review comment for lp:~jameinel/bzr/1.18-switch-branch

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

John A Meinel wrote:
...

>>>>
>>> I'm not sure if you noticed that I already check: "if '/' in to_location".
>>>
>>> I'm not sure what more than that you need. (I even added tests for this
>>> case....)
>> Oh oops :P. However I think thats more prohibitive than needed - in
>> particular I use subdirs not a flat branch space. What do you thank of
>> the slightly more sophisticated heuristic I proposed?
>
>> -Rob
>
>
> You're welcome to write it?
>
> John
> =:->
>

More seriously, I think it would be reasonable to do so, but if you
really do use nested values, then when you want to do "../another/dir"
it will look like you are doing something relative to the current dir.

I've proposed in the past that if you did:

  bzr switch bar/baz

That it would treat it as
  bzr switch $ORIG/../../bar/baz

However, we don't do that *today* so what I wrote is consistent with
what we have.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkpXuVsACgkQJdeBCYSNAANCCACgsV1IqHX0CERE0SgqB/8rPptr
wLYAoJ/M5VYsWRVLL/q5ZdpG1MKoE4f/
=JxmI
-----END PGP SIGNATURE-----