Code review comment for lp:~jameinel/bzr/2.0-40412-show-base-weave

Revision history for this message
Vincent Ladeuil (vila) wrote :

Mentioning https://bugs.edge.launchpad.net/bzr/+bug/40412 and https://bugs.edge.launchpad.net/bzr/+bug/494204 here as courtesy URLs for those watching from home ;)

Do you really intend to land plan_to_base.py ?
If that's the case, contrib may be a more appropriate place no ?
Or did you just forget to delete it before submission (the code looks
like a preliminary version of your patch).

I don't know what happened here but lp is showing conflicts in the diff... which are not there when I review locally on my machine... tricked by the markers in the diff itself ? Weird.

Anyway, if plan_to_base.py is spurious, you can land without it.

review: Needs Fixing

« Back to merge proposal