Code review comment for lp:~jameinel/bzr/2.0.4-faster-export-343218

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Martin Pool wrote:
> 2009/12/18 John A Meinel <email address hidden>:
>> So you can't set file perms to a plain 'open()' call. The mode flag is 'rb' versus 'wb', etc.
>>
>> You can, however use "os.open()" to get a raw file descriptor and then you get more flags. (os.open(, O_CREAT, 0777), etc.)
>>
>> I'll change that.
>>
>> However, my patch isn't a user-visible change (as I understand it). Or are you saying the chmod is a 2.0 borderline?
>>
>> It *does* change the order that files will get created in the export. However, once they are in the filesystem, you can't really tell that. I did *not* change the ordering for tarball or zip exports.
>
> oh, I thought (from some other comments) you might also be changing it
> in tar files, which would be slightly user visible. Obviously this is
> not, so it's ok.
>

I sent a mail to the list for discussing my 2.1 version of the patch,
asking what people thought about possibly changing the ordering.

Of course, nobody has responded to that...

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAksq4OsACgkQJdeBCYSNAAOmlwCfRqedgu6YXLBhbQ3d1fxjPRZB
f70AoNQkGKw0bI9f5gZhdtq/p2ZD2clp
=fgyf
-----END PGP SIGNATURE-----