Code review comment for lp:~jameinel/bzr/2.1-categorize-requests-819604

Revision history for this message
John A Meinel (jameinel) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 10/8/2011 10:36 PM, Martin Packman wrote:
> Review: Approve
>
> I like this, it's good documentation.
>
> Miscellaneous gripe, the word 'safe' is overused in naming things.
> It requires context to know what it really means, and that tends to
> be lost when if the terminology spreads to multiple places.

What would you prefer? 'readonly' and 'idempotent'?

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk6Qu+cACgkQJdeBCYSNAAOs+ACgi8HFJBojvw0iped3kFIdhmbL
jz8AnilOZIjH01WF61WxA0eWAmQ4/N0N
=BPTN
-----END PGP SIGNATURE-----

« Back to merge proposal