Bazaar

Code review comment for lp:~jameinel/bzr/2.1-remove-win32-build

  1. 2.1-remove-win32-build
  2. Merge into bzr.dev
Revision history for this message
John A Meinel (jameinel) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Ian Clatworthy wrote:
> Review: Needs Fixing
> My understanding is that win32/ostools.py can't be deleted. Please check with bialix for the reasons.
>
> Otherwise, this all looks ok to me.

I did grep around for it, as I originally wanted to remove *everything*
in that directory.

I see 'ostools.py' used in Makefile and build-installer.bat.in

Both of which should be using the bzr-windows-installers code.

Are you thinking that there is a 3rd-party code out there that is going
to be using our 'ostools.py' file?

(Like scmproj, qbzr, etc.)

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkrlnE8ACgkQJdeBCYSNAAP95QCfdbVMCpvisBtqigvNRCUtyZTN
A2kAoNWvmtfl8wagJI0dPPSCyVdRuupH
=LMk3
-----END PGP SIGNATURE-----

Reply

« Back to merge proposal