Bazaar

Code review comment for lp:~jameinel/bzr/2.1-remove-win32-build

  1. 2.1-remove-win32-build
  2. Merge into bzr.dev
Revision history for this message
John A Meinel (jameinel) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Alexander Belchenko wrote:
>> This removes some of the win32 build cruft from the bzr codebase.
>> Unfortunately I cannot (yet) remove all of it, because a decent portion of the
>> build process still uses the code from here. (Namely we run 'iscc bzr.iss' on
>> the file from the bzr source, rather than using that file from bzr-windows-
>> installers. This should get fixed.
>
> It's not quite true. When installer is building the actual bzr.iss.cog file copied from bzr-windows-installers codebase. Then bzr.iss.cog converted to bzr.iss with cog.py utility.
>

That is good to hear. Though I know I've run into problems in the past
with the installer looking in the wrong place for files. However, the
more we push on this the better we'll get. :)

I'd really like to overhaul most of the build process, though I don't
think I'll get to that soon.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkrm/8oACgkQJdeBCYSNAAPvaQCdGTQ6JFdcqNdhycl24vDxvKps
qmcAn0HJc9BV+DRj3TqhdKEstWE83BsZ
=tzX+
-----END PGP SIGNATURE-----

Reply

« Back to merge proposal