Bazaar

Code review comment for lp:~jameinel/bzr/2.1-remove-win32-build

  1. 2.1-remove-win32-build
  2. Merge into bzr.dev
Revision history for this message
Alexander Belchenko (bialix) wrote :

John, Ian.

I can't say for sure does ostools.py still used by windows-installer process, but I found next lines in build-installer.bat.in

echo Building the C extensions
cd %TARGET%
%PYTHON% tools/win32/ostools.py remove bzrlib/*.pyd
%PYTHON% setup.py build_ext -i -f %PYTHON_BUILDFLAGS%
@if %ERRORLEVEL% NEQ 0 (set BUILD_ERROR=%ERRORLEVEL%) & goto End

It seems that at least this line rely on the fact that ostools.py present in bzr.dev codebase.
So if you want to remove ostools.py from bzr.dev I suspect you have to fix installer bat file first.

The snippet above taken from revno 46 of bzr+ssh://bazaar.launchpad.net/~bzr/bzr-windows-installers/trunk/

Vincent, does babune supposed to catch that sort of build errors? Or it unable to build installer from bzr.dev?

Reply

« Back to merge proposal