Code review comment for lp:~jameinel/bzr/2.1-static-tuple-chk-map

Revision history for this message
Andrew Bennetts (spiv) wrote :

Looks ok, it's mostly mechanical despite the large line count. A couple of questions:

772 - self.parent_id_basename_to_file_id.key())
773 + (self.parent_id_basename_to_file_id.key()[0],))

That change (and the other similar ones looks a bit odd.

Oh, is that how you're casting a StaticTuple to a tuple for string formatting? I would have thought "x.as_tuple()" would be about as fast as "(x[0],)", and it's certainly more readable. I suppose it is noticeably slower?

1115 -class TestSearchKeyFuncs(tests.TestCase):

Why delete this TestCase?

review: Approve

« Back to merge proposal