Bazaar

Code review comment for lp:~jameinel/bzr/2.1.0b3-win32-shell-completion

  1. 2.1.0b3-win32-shell-completion
  2. Merge into bzr.dev
Revision history for this message
Alexander Belchenko (bialix) wrote :

I've late here but I want to say my word.

John, I agree with Martin that using single quotes is bad idea. I hope you decided to remove them. All Windows people used to double quotes so single quotes is not Windows way.

Also I think will be nice to have a way to disable this glob expansion via environment variable, e.g. BZR_GLOB=0 or BZR_GLOB=no. Using configs there is wrong idea, but os.environ should be OK and fast.

review: Needs Fixing

« Back to merge proposal