Bazaar

Code review comment for lp:~jameinel/bzr/2.1.0rc1-set-mtime

  1. 2.1.0rc1-set-mtime
  2. Merge into bzr.dev
Revision history for this message
Martin Packman (gz) wrote :

Ack, okay, I've tested this here and there are some outstanding issues I didn't see eyeballing the code. I'll get them myself and push a branch rather than making you do more work though.

* The tests for "same second" need to use round() rather than int()
* GetFileInformationByHandleEx/FILE_BASIC_INFO is Vista-or-later (hence LARGE_INTEGER usage, it's just FILETIME with better struct-packing on 64bit).

I'll replace that with SetFileTime, shout if you can think of a reason not to.

« Back to merge proposal