Code review comment for lp:~jameinel/bzr/2.1.0rc1-set-mtime

Revision history for this message
Martin Packman (gz) wrote :

> Since there is precedent, we could probably go the ..._thunk() route.

Well, my point was more that there's all sorts of different precedent, which is why I get confused.

> I think I've decided to go a different way, which is to just use
> 'os.utime()' for all code paths
>
> In my timing tests, I can't find a benefit to custom extensions. And as
> such, the reasonable default is to use the less complex implementation.
>
> I've now pushed up that version. It certainly is a lot simpler overall.

Okay, this sounds like a good choice.

review: Approve

« Back to merge proposal