Code review comment for lp:~jameinel/bzr/2.1.0rc1-set-mtime

Revision history for this message
John A Meinel (jameinel) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Vincent Ladeuil wrote:
> Review: Approve
> Sounds good !
>
> Just a nit:
>
> 8 +* Operations which update the working tree should now create all files
> 9 + with the same mtime.
>
> When reading this I had slight doubt about whether modified files were also concerned.
>
> I know they are, but saying create/modify instead of just create may make it clearer.

Well, we create all files from scratch, and then rename them into place.
But sure, I'll reword it a bit.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAktGAN4ACgkQJdeBCYSNAAMCDgCfXc4/KLGg7b+X7AcwKh2BY5wA
qLUAoMZXaBmeZm8tt6XjYylXfZsAAKM8
=AbBM
-----END PGP SIGNATURE-----

« Back to merge proposal