Code review comment for lp:~jameinel/bzr/2.3-filter-tests
Revision history for this message
| Robert Collins (lifeless) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
so for skip I think keeping the log is important, it may well have
hints to why something gets skipped beyond the reason; for xfail this
makes sense to me.
Looking at the implementation, I'd rather see discardDetail in
testtools upstream - no need to do it in bzr at all.
But, I don't think its correct, you say that the log becomes part of
the reason, but that doesn't make sense at all.
Whats the size issue with PQM? We don't skip all that many tests...
-Rob