Code review comment for lp:~jameinel/bzr/2.3-filter-tests

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 8/29/2010 3:34 AM, Robert Collins wrote:
> so for skip I think keeping the log is important, it may well have
> hints to why something gets skipped beyond the reason; for xfail this
> makes sense to me.
>
> Looking at the implementation, I'd rather see discardDetail in
> testtools upstream - no need to do it in bzr at all.
>
> But, I don't think its correct, you say that the log becomes part of
> the reason, but that doesn't make sense at all.
>
> Whats the size issue with PQM? We don't skip all that many tests...
>
> -Rob

We skip 2200 tests, and it causes the log file to become 7.2MB in size.
I would consider that both "many tests" and a "large output".

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkx6YGsACgkQJdeBCYSNAAPqZwCZAUQod44FAGp2akiiR5mS+5mV
4SkAn0SKZCP/szWfI8gXQbyLE8mWk4p9
=lx8l
-----END PGP SIGNATURE-----