Code review comment for lp:~jameinel/bzr/2.3-filter-tests

>>>>> John Arbash Meinel <email address hidden> writes:

    > On 8/30/2010 9:53 AM, Vincent Ladeuil wrote:
    >> As a data point, I still can't get any email from PQM on failures.
    >>
    >> I just had to reproduce a problem and the raw selftest.log containing the uncompressed,
    >> unfiltered, selftest.log is 47M.
    >>
    >> I'm not quite sure about which stream is sent on failure but I suspect it is this one.
    >>
    >> So, for debugging purposes, I don't like removing stuff.
    >> But I currently get *nothing* so can we step back a bit and addresses this
    >> problem once and for all ?
    >>
    >> Should we send a very short mail on failures with an url to get the whole stream for example ?

    > Do you really feel that including the log output for xfail, skip, and
    > success is adding useful info?

No. But you forgot 'not applicable' :-P

    > *I* feel it is just adding a lot of noise with almost 0 signal...

Right, so ISTM that we agree about two things:

- we want the list of tests and their status (pass/fail/skip etc.)
- we care about log only for failures.

Don't we get that by simply *not* using subunit on pqm ?

Or is pqm.bazaar-cvs.org *requiring* subunit ?