Code review comment for lp:~jameinel/bzr/2.3-filter-tests

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

...

> > - turn off subunit (will reduce some of the overhead - lots in a
> > success case, but in a it-all-goes-pear-shaped failure, you'll
> > still hit the limit and whatever undiagnosed and unfixed issue is
> > biting you now, will bite you then.
>
> Yup, exactly my feeling.
>
> > - diagnose and fix the mailer path issue so that you receive the
> > mails reliably
>
> As a data point, John got an email for a failure and *I* didn't get it
> for the same failure (or so very closely the same failure that the
> difference doesn't matter).

Right. For that 'failure' there was a single test failing. And the size
of the compressed log is 3.2MB, which makes it about 7MB according to
Thunderbird. (Figure base64 encoding, and ?).

It is true that if you have a huge 'everything fails' case, you'll still
get into that range. Though I did have one of those recently that broke
the 10MB barrier and caused the mail to fail to reach me. Which was,
indeed, much harder for me to track down and fix.

However, getting rid of 7MB (of compressed+base64) success content would
get a lot more headroom for when a few tests fail (or even a few hundred
fail).

...

> > To stop using email to send the results, we either need to design
> > a new thing and change PQM to do it, or reenable the LP API
> > support, which Tim requested we disable.
>
> And what would that give us ? Failed run stream attached to the mp as an
> attachment ?

I don't think you can attach stuff to an MP. I think it would actually
try to set it as a message...

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkx9JG0ACgkQJdeBCYSNAAMWcQCgrPHen1zB4dpr7AR1vJToTKxc
3BwAnR8AFECkruco07VCTPhTpFYFu8Xt
=jceX
-----END PGP SIGNATURE-----