Code review comment for lp:~jameinel/bzr/2.3-filter-tests

Revision history for this message
Martin Pool (mbp) wrote :

This is now a couple of weeks old and I'd like to wrap it up.

I think it would be reasonable to merge it, and at least see what we think about it. I cannot recall looking at the logs attached to an xfail, skip or notapplicable test for a long time. The normal and common thing is that they'll have a fairly selfexplanatory message about being either known broken, or skipped because of a missing dependency, or whatever. In the source, the code that raises that exception is normally pretty obvious. If the test is being wrongly skipped, then the logs probably won't help and you need to dig in with pdb or something.

There is some unhelpful data logged by bzr and we could push down on that too.

On the whole I'm ok to merge this; it seems like it's just a couple of lines to turn it back on if we need to.

review: Approve

« Back to merge proposal