Code review comment for lp:~jameinel/bzr/2.3-filter-tests

Revision history for this message
Martin Packman (gz) wrote :

If this is going to land, there are some things that should really be fixed first.

+ self._suppress_log ()

No space.

+ def _report_skip(self, result, e):

Rather than adding this, put the call in _do_skip instead?

ExtendedTestResult.addSuccess appears to have a similar hack spelt in a different way:

        test._log_contents = ''

Remove that and add your new version instead?

Would really like some kind of test.

review: Needs Fixing

« Back to merge proposal