Code review comment for lp:~jameinel/bzr/test-traceback-767177

Revision history for this message
Martin Packman (gz) wrote :

I don't really like the semantics here, but it's mostly inherited I guess. Making the close call more deterministic is good, but there's too much indentation already.

As _seek_and_read is very nearly a static method, and doubles as a cache, wouldn't pulling it out into a separate iterator class make it easier to follow?

review: Abstain

« Back to merge proposal