Code review comment for lp:~jameinel/launchpad/lp-service

Revision history for this message
John A Meinel (jameinel) wrote :

setsid() is recommended from the daemonize code I've read:
  http://www.itp.uzh.ch/~dpotter/howto/daemonize

os.chdir('/') is sort of recommended, but doesn't seem to be required.

I moved the '/dev/null' definition closer.

I think that addresses everything. If you could give it a once-over and then send it via ec2land, I would appreciate it.

« Back to merge proposal