Code review comment for lp:~james-w/indicator-applet/messages-icons

Revision history for this message
Matthew Paul Thomas (mpt) wrote :

Thanks for the contribution, but I'd rather we didn't do this, for two reasons. First, the applications are generally not as important as the actual message sources, and giving icons only to the latter makes them more visible. Second, without an icon the application name items subtly double as headings for the application sections, and they'd lose that effect if they had icons too.

I've updated the spec to clarify this. <https://wiki.ubuntu.com/MessagingMenu?action=diff&rev2=10&rev1=8> (BTW, whenever I include -- or omit -- something in a mockup, there's usually a precise reason, so feel free to ask if I haven't documented it anywhere.)

review: Disapprove (ux)

« Back to merge proposal