Code review comment for lp:~james-w/indicator-applet/messages-icons

On Tue, 2009-04-07 at 12:15 +0000, Matthew Paul Thomas wrote:
> Review: Disapprove ux
> Thanks for the contribution, but I'd rather we didn't do this, for two reasons.

Fair enough.

> Second, without an icon the application name items subtly double as headings
> for the application sections, and they'd lose that effect if they had icons too.

There is an indent to the messages that also makes the application name
appear as a header.

Also, when there are no messages without icons I don't think it looks
very attractive, maybe something else can be done to alleviate that, or
perhaps you disagree.

> I've updated the spec to clarify this. <https://wiki.ubuntu.com/MessagingMenu?action=diff&rev2=10&rev1=8>
> (BTW, whenever I include -- or omit -- something in a mockup, there's usually a precise reason,
> so feel free to ask if I haven't documented it anywhere.)

I appreciate that, but I disagreed, and putting the patch together took
little time and allowed me to show what it would look like.

Thanks,

James