Code review comment for lp:~james-w/indicator-applet/messages-icons

James Westby wrote:
> I never included a reference to a little video I made here, sorry.
>
> http://jameswestby.net/images/empathy-indicator.ogv
>
Looking at that, I think the current spec is correct, -1 to this change.

 review -1
 status rejected

The icons create unnecessary clutter. Our general policy is to decrease,
not increase the number of icons in menus. We make some exceptions to
this, but they have to be carefully justified and debated.

> As for whether this was better to code or mockup, by the time I had
> dug far enough in to the code to see that this wasn't implemented
> rather than just buggy as I initially suspected I could see how to
> do the work, not to mention that I am far more adept at coding
> than Gimp or Inkscape.
>
You can do better than this, James. I don't want to discourage you, but
this was not a very smart response or approach. There are other areas
that require your coding attention, I think primarily of a specific
project assigned to you from me in person. Digging in first is a
kneejerk reaction - if you thought it was a bug, file it first to see
what conversations it triggers.

Please take an afternoon to learn enough Gimp or Inkscape to be able to
produce that mockup in 20 minutes. They are both great pieces of free
software, and will help you to participate in the design conversations
productively.

If you think I'm out of line, think again carefully. I want you to
participate, but I have every right to ask you to do so effectively, and
you're missing a trick here.

Mark