Code review comment for lp:~james-w/launchpad/archive-job-db

Revision history for this message
Stuart Bishop (stub) wrote :

Generally fine.

patch-2207-64-0.sql

I think the job foreign key constraint should be ON DELETE CASCADE to make job garbage collection a little easier:

job integer NOT NULL CONSTRAINT archivejob__job__fk REFERENCES job ON DELETE CASCADE

(the archive foriegn key constraint should not be).

« Back to merge proposal