Code review comment for lp:~james-w/launchpad/archive-job-db

Revision history for this message
James Westby (james-w) wrote :

On Fri, 25 Jun 2010 07:41:28 -0000, Stuart Bishop <email address hidden> wrote:
> Oh... please fix the security.cfg declarations. The [write] section is deprecated per the comments. Please add explicit permissions to users.

I was just cargo-culting, so I'm not surprised it is wrong.

I guess the other permission is ok?

I don't know what explicit permissions other than that would be needed.

Currently these jobs would be added by a script run by an admin on
request, and then we will add a cronscript to process them. If you can
tell me what users/permission might be needed for that then I can add
them now, otherwise I will just leave the default in and work with the
Soyuz team on making other changes needed once we have something to test
on dogfood.

Thanks,

James

« Back to merge proposal