James, this all looks good.
My only comment is about the codeimport doc test.
How much work is it to change the following line:
>>> target = IBranchTarget(getUtility(IProductSet).getByName('firefox'))
to use factory.makeProduct(name='widget') ?
I'd love to move more away from sample data in the tests.
« Back to merge proposal
James, this all looks good.
My only comment is about the codeimport doc test.
How much work is it to change the following line:
>>> target = IBranchTarget( getUtility( IProductSet) .getByName( 'firefox' ))
to use factory. makeProduct( name='widget' ) ?
I'd love to move more away from sample data in the tests.