Code review comment for lp:~james-w/launchpad/copy-archive-package-sets

Revision history for this message
Graham Binns (gmb) wrote :

Hi James,

One minor nitpick but otherwise this branch is r=me.

> === modified file 'lib/lp/soyuz/adapters/packagelocation.py'
> --- lib/lp/soyuz/adapters/packagelocation.py 2009-08-28 06:39:38 +0000
> +++ lib/lp/soyuz/adapters/packagelocation.py 2010-06-22 12:11:56 +0000
> @@ -63,6 +66,10 @@
> if self.component is not None:
> result += ' (%s)' % self.component.name
>
> + if self.packagesets:

We should explicitly test len() here, since we know it's going to be a
list even if it's empty.

> + result += ' [%s]' % (
> + ", ".join([str(p.name) for p in self.packagesets]),)
> +
> return result
>
>

review: Approve (code)

« Back to merge proposal