Code review comment for lp:~james-w/launchpad/create-source-recipe-build

Revision history for this message
Julian Edwards (julian-edwards) wrote :

Looks good, just a few small tweaks. Landing is conditional on fixing these and your TODO!

* Please document the fact that requestBuild raises exceptions in the interface docstring.
* it's "targeted" not "targetted"
* Our coding standards say that you should format method invocations like this:

    method(
        arg, arg, arg)

 i.e. newline after the opening parens.

* Also indent 4 chars only

Nice tests!

review: Approve (code)

« Back to merge proposal