Launchpad itself

Code review comment for lp:~james-w/launchpad/sync-source-negative-versions

sync-source-negative-versions
Merge into devel

Revision history for this message

James Westby (james-w) wrote on 2010-01-05:

Fixes a problem found by geser with syncing new packages
that have odd version numbers.

A version can be 0~bzr123-1 or similar, which comapares
to less than 0. However, 0 was being used to mean "not
in Ubuntu," so sync-source.py considered the package to be
absent.

This change makes it use a proper sentinel, None, when
the package is new, so we can't get caught out by odd
comparisons.

Thanks,

James

Fixes a problem found by geser with syncing new packages                                                                                                     
that have odd version numbers.                                                                                                                               
                                                                                                                                                             
A version can be 0~bzr123-1 or similar, which comapares                                                                                                      
to less than 0. However, 0 was being used to mean "not                                                                                                       
in Ubuntu," so sync-source.py considered the package to be                                                                                                   
absent.                                                                                                                                                      
                                                                                                                                                             
This change makes it use a proper sentinel, None, when                                                                                                       
the package is new, so we can't get caught out by odd                                                                                                        
comparisons.                                                                                                                                                 
                                                                                                                                                             
Thanks,                                                                                                                                                      
                                                                                                                                                             
James

« Back to merge proposal