Code review comment for lp:~james-w/lazr.restfulclient/fix-caching

Revision history for this message
Abel Deuring (adeuring) wrote :

(17:45:06) adeuring: james_w: this looks like a really good bug fix! Just two formal nitpicks: (1) Could you move the last parameter in the changed call on a new line? we try to keep the length <= 78 characters. (2) I think most of your commit message is worth to appear as a comment for the changed method call so that readers know why http_method.upper() makes sense here?
(17:45:36) james_w: makes sense

review: Approve (code)

« Back to merge proposal