Code review comment for lp:~james-w/lazr.restfulclient/fix-caching

Revision history for this message
Leonard Richardson (leonardr) wrote :

I don't think this branch will help performance. I believe a named operation that returns an entry will not serve an ETag or respect a conditional GET, which means that a conditional GET will never succeed. And because Launchpad doesn't serve any cache directives, httplib2 will always try to get the freshest version of the resource, which means invoking the named operation again. Those are the two ways a client-side cache can help performance, and neither is applicable.

I could be wrong, and that's not a reason not to land this branch, because it does improve the code. But I would like to see a test (maybe in caching.txt) that shows what the effect of this branch is. Even if the only effect is that the outgoing HTTP request looks different.

« Back to merge proposal