Code review comment for lp:~james-w/lazr.restfulclient/improve-collection-fetch-optimisation

Revision history for this message
James Westby (james-w) wrote :

Hi,

This change helps with fetching large collections. There is
on optimisation that sets the desired page size if it looks
like a full page will be unneeded, but the way it was coded
meant that the first fetch was always full.

The change here means that the optimisation is more widely applied,
but critically for me you can actually control the size of the fetches
my looping the slices. Some API calls are liable to timeout, so
chunking them smaller allows you to use them, and that's currently
not possible. With this change you can iterate slices to control
the page size.

Thanks,

James

« Back to merge proposal