Code review comment for lp:~james-w/subunit/discovery

Revision history for this message
Robert Collins (lifeless) wrote :

On Wed, Jun 23, 2010 at 7:34 AM, James Westby <email address hidden> wrote:
> I wasn't using trunk.
>
>
> Doing what you ask is possible, but means we move further from 2.7's
> TestProgram, and don't pick up extra options in the usage output
> that easily. That at least would go away once 2.7 was the minimum.
>
> I'm happy to do that if you like

We should file patches for changes we make that are relevant to the
reusability of TestProgram in python upstream; simple porting changes
aren't relevant because - well that obvious :).

So far, I checked and our changes didn't need upstream patches; we may
at this point need to send one in, and thats fine IMO.

We don't need to block on sending such a patch in, we should get
something we're happy with, then send in a patch.

-Rob

« Back to merge proposal