wadllib

Merge lp:~james-w/wadllib/fix-doctests into lp:wadllib

  1. fix-doctests
  2. Merge into trunk
Proposed by James Westby
Status: Rejected
Rejected by: Gavin Panella
Proposed branch: lp:~james-w/wadllib/fix-doctests
Merge into: lp:wadllib
Diff against target: None lines
To merge this branch: bzr merge lp:~james-w/wadllib/fix-doctests
Reviewer Review Type Date Requested Status
Gavin Panella Needs Information
Review via email: mp+8476@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Gavin Panella (allenap) :
review: Approve
Revision history for this message
Gavin Panella (allenap) wrote :

Hi James, the doctest flags you request are set in src/wadllib/tests/test_docs.py now. They may not have been at the time you wrote this patch, but currently it seems that this isn't needed. Can you confirm that?

review: Needs Information
Revision history for this message
James Westby (james-w) wrote :

On Fri Sep 25 14:02:11 UTC 2009 Gavin Panella wrote:
> Review: Needs Information
> Hi James, the doctest flags you request are set in
> src/wadllib/tests/test_docs.py now. They may not have been at the time you
> wrote this patch, but currently it seems that this isn't needed. Can you
> confirm that?

Yes, that seems to be appropriate. I think this requested can be rejected.
Thanks for the review.

James

Unmerged revisions

8. By James Westby

Turn on the needed doctests extensions for the tests.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'wadllib/docs/wadllib.txt'
2--- wadllib/docs/wadllib.txt 2009-01-22 15:35:49 +0000
3+++ wadllib/docs/wadllib.txt 2009-02-16 15:36:42 +0000
4@@ -265,7 +265,7 @@
5 ['person-acceptInvitationToBeMemberOf', 'person-addMember', 'person-declineInvitationToBeMemberOf']
6
7 >>> bound_limi = bind_to_testdata(limi_person, 'person-limi')
8- >>> sorted(bound_limi.parameter_names())[:3]
9+ >>> sorted(bound_limi.parameter_names())[:3] # doctest: +NORMALIZE_WHITESPACE
10 ['admins_collection_link', 'confirmed_email_addresses_collection_link',
11 'date_created']
12 >>> languages_link = bound_limi.get_parameter("languages_collection_link")
13@@ -372,7 +372,7 @@
14
15 >>> bound_root.get_parameter('a_date').get_value()
16 datetime.datetime(2007, 10, 20, 0, 0)
17- >>> bound_root.get_parameter('a_datetime').get_value()
18+ >>> bound_root.get_parameter('a_datetime').get_value() # doctest: +ELLIPSIS
19 datetime.datetime(2005, 6, 6, 8, ...)
20
21 A 'date' field can include a timestamp, and a 'datetime' field can
22@@ -385,7 +385,7 @@
23
24 >>> bound_root.get_parameter('a_datetime').get_value()
25 datetime.datetime(2007, 10, 20, 0, 0)
26- >>> bound_root.get_parameter('a_date').get_value()
27+ >>> bound_root.get_parameter('a_date').get_value() # doctest: +ELLIPSIS
28 datetime.datetime(2005, 6, 6, 8, ...)
29
30 If a date or dateTime parameter has a null value, you get None. If the

Subscribers

People subscribed via source and target branches