wadllib

Merge lp:~james-w/wadllib/fix-doctests into lp:wadllib

  1. fix-doctests
  2. Merge into trunk
Proposed by James Westby
Status: Rejected
Rejected by: Gavin Panella
Proposed branch: lp:~james-w/wadllib/fix-doctests
Merge into: lp:wadllib
Diff against target: None lines
To merge this branch: bzr merge lp:~james-w/wadllib/fix-doctests
Reviewer Review Type Date Requested Status
Gavin Panella Needs Information
Review via email: mp+8476@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Gavin Panella (allenap) :
review: Approve
Revision history for this message
Gavin Panella (allenap) wrote :

Hi James, the doctest flags you request are set in src/wadllib/tests/test_docs.py now. They may not have been at the time you wrote this patch, but currently it seems that this isn't needed. Can you confirm that?

review: Needs Information
Revision history for this message
James Westby (james-w) wrote :

On Fri Sep 25 14:02:11 UTC 2009 Gavin Panella wrote:
> Review: Needs Information
> Hi James, the doctest flags you request are set in
> src/wadllib/tests/test_docs.py now. They may not have been at the time you
> wrote this patch, but currently it seems that this isn't needed. Can you
> confirm that?

Yes, that seems to be appropriate. I think this requested can be rejected.
Thanks for the review.

James

Unmerged revisions

8. By James Westby

Turn on the needed doctests extensions for the tests.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'wadllib/docs/wadllib.txt'
--- wadllib/docs/wadllib.txt 2009-01-22 15:35:49 +0000
+++ wadllib/docs/wadllib.txt 2009-02-16 15:36:42 +0000
@@ -265,7 +265,7 @@
265 ['person-acceptInvitationToBeMemberOf', 'person-addMember', 'person-declineInvitationToBeMemberOf']265 ['person-acceptInvitationToBeMemberOf', 'person-addMember', 'person-declineInvitationToBeMemberOf']
266266
267 >>> bound_limi = bind_to_testdata(limi_person, 'person-limi')267 >>> bound_limi = bind_to_testdata(limi_person, 'person-limi')
268 >>> sorted(bound_limi.parameter_names())[:3]268 >>> sorted(bound_limi.parameter_names())[:3] # doctest: +NORMALIZE_WHITESPACE
269 ['admins_collection_link', 'confirmed_email_addresses_collection_link',269 ['admins_collection_link', 'confirmed_email_addresses_collection_link',
270 'date_created']270 'date_created']
271 >>> languages_link = bound_limi.get_parameter("languages_collection_link")271 >>> languages_link = bound_limi.get_parameter("languages_collection_link")
@@ -372,7 +372,7 @@
372372
373 >>> bound_root.get_parameter('a_date').get_value()373 >>> bound_root.get_parameter('a_date').get_value()
374 datetime.datetime(2007, 10, 20, 0, 0)374 datetime.datetime(2007, 10, 20, 0, 0)
375 >>> bound_root.get_parameter('a_datetime').get_value()375 >>> bound_root.get_parameter('a_datetime').get_value() # doctest: +ELLIPSIS
376 datetime.datetime(2005, 6, 6, 8, ...)376 datetime.datetime(2005, 6, 6, 8, ...)
377377
378A 'date' field can include a timestamp, and a 'datetime' field can378A 'date' field can include a timestamp, and a 'datetime' field can
@@ -385,7 +385,7 @@
385385
386 >>> bound_root.get_parameter('a_datetime').get_value()386 >>> bound_root.get_parameter('a_datetime').get_value()
387 datetime.datetime(2007, 10, 20, 0, 0)387 datetime.datetime(2007, 10, 20, 0, 0)
388 >>> bound_root.get_parameter('a_date').get_value()388 >>> bound_root.get_parameter('a_date').get_value() # doctest: +ELLIPSIS
389 datetime.datetime(2005, 6, 6, 8, ...)389 datetime.datetime(2005, 6, 6, 8, ...)
390390
391If a date or dateTime parameter has a null value, you get None. If the391If a date or dateTime parameter has a null value, you get None. If the

Subscribers

People subscribed via source and target branches