Code review comment for lp:~james-w/wadllib/fix-simplejson-unicode

Revision history for this message
James Westby (james-w) wrote :

Hi,

Please see http://code.google.com/p/simplejson/issues/detail?id=40

This means that the output of simplejson.loads changes depending on
the version of simplejson, and whether the C speedups are in use,
unless you always pass in unicode.

This meant that the tests would fail on some systems, but also that
you couldn't rely on the output.

This change ensures that all parsed strings will be unicode, as the
tests assert.

Thanks,

James

« Back to merge proposal