Code review comment for lp:~jamestait/rnr-server/sca-conn-check-301

Revision history for this message
Daniel Manrique (roadmr) wrote :

You're changing a 302 (found, nothing else changes) to a 301 (redirect). I guess the question is, which URL will conn-check look for? if it's happy with the wanted URL giving a 301, regardless of the Location: header and won't do anything crazy like following the redirect until it gets a more definitive code, then this is fine. If, OTOH, conn-check follows the redirect, then I suspect the URL would need updating to the target one.

So this looks OK in principle, just need to clarify this bit.

« Back to merge proposal