go-home-applet

Merge lp:~jassmith/go-home-applet/atk into lp:go-home-applet

  1. atk
  2. Merge into trunk
Proposed by Jason Smith
Status: Merged
Merged at revision: not available
Proposed branch: lp:~jassmith/go-home-applet/atk
Merge into: lp:go-home-applet
Diff against target: None lines
To merge this branch: bzr merge lp:~jassmith/go-home-applet/atk
Reviewer Review Type Date Requested Status
David Barth (community) Approve
Mirco Müller (community) Abstain
Eitan Isaacson Pending
Review via email: mp+10741@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Jason Smith (jassmith) wrote :

Makes a11y work with the proper orca config, however this really will need feedback from the a11y community as I am not a user with these needs.

lp:~jassmith/go-home-applet/atk updated
31. By Jason Smith <jason@t500>

translatable strings

Revision history for this message
Mirco Müller (macslow) wrote :

Good, translatable strings are in. Still regarding general use of ATK I'd rather see Eitan "eeejay" Isaacson comment on that.

review: Abstain
Revision history for this message
David Barth (dbarth) wrote :

Same as the other ATK patch. Go ahead.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/applet.c'
--- src/applet.c 2009-02-16 12:27:20 +0000
+++ src/applet.c 2009-08-26 14:11:40 +0000
@@ -321,6 +321,7 @@
321 WnckScreen *screen;321 WnckScreen *screen;
322 GoHomeApp *app;322 GoHomeApp *app;
323 GtkWidget *eb;323 GtkWidget *eb;
324 AtkObject *atk;
324 gchar *key;325 gchar *key;
325326
326 if (strcmp (iid, "OAFIID:GNOME_GoHome") != 0)327 if (strcmp (iid, "OAFIID:GNOME_GoHome") != 0)
@@ -373,6 +374,11 @@
373374
374 gtk_widget_show_all (GTK_WIDGET (applet));375 gtk_widget_show_all (GTK_WIDGET (applet));
375 376
377 atk = gtk_widget_get_accessible (app->image);
378 atk_object_set_name (atk, "Go Home");
379 atk_object_set_description (atk, "Go home, show the home window.");
380 atk_object_set_role (atk, ATK_ROLE_PUSH_BUTTON);
381
376 /* Signals */382 /* Signals */
377 g_signal_connect (applet, "change-background",383 g_signal_connect (applet, "change-background",
378 G_CALLBACK (cw_panel_background_changed), NULL);384 G_CALLBACK (cw_panel_background_changed), NULL);

Subscribers

People subscribed via source and target branches

to all changes: