Code review comment for lp:~javierder/qbzr/send

Javier Der Derian пишет:
> Javier Der Derian has proposed merging lp:~javierder/qbzr/send into lp:qbzr.
>
> Requested reviews:
> QBzr Developers (qbzr-dev)
>
> I've built a QT dialog for Send Command.
>
> Features:
> * loads into target branch combobox the saved submit branch
> * Allows to send email or save to file, allowing to choose which file to save using a filesave dialog
> * Allows to add a message
> * Allows "no bundle", "no patch" and "remember" options
> * Validates email
>
> I'm eager to hear you inputs!

Several small tweaks needed:

1) Help string:

C:\work\Bazaar\plugins\qbzr>bzr qsend -h
Purpose: Dialog for creating and sending patchs and bundles
Usage: bzr qsend [SUBMIT_BRANCH] [PUBLIC_BRANCH]

Fix spelling in help string: s/patchs/patches/

2) When I'm running qsend I'm get warning in the console:

C:\work\Bazaar\plugins\qbzr>bzr qsend
Object::connect: No such slot QVBoxLayout::setDisabled(bool)

So you're using not compatible API with PyQt 4.3. Please look at other dialogs, and fix this.

3) You shows internal bzr name in the title of group box:

Branch to submit:BzrBranch7('file:///C:/work/Bazaar/repos/qbzr-repo-1.9/send')

Instead you should use url_for_display(branch.base) to obtain fine string.

4) I found your dialog is hard to understand: what all this options means and in which lineedit
element I should enter what? Especially lineedit below radiobuttons. Why for Message is needed?

I'd like to rework the UI. I'll explain it shortly. But to discuss the UI it's better to see
screenshots, so it's better to continue discussion in the google group.