Merge lp:~jbicha/syncevolution/fix-gcc6-ftbfs into lp:~phablet-team/syncevolution/ubuntu

Proposed by Jeremy Bícha
Status: Merged
Merged at revision: 4643
Proposed branch: lp:~jbicha/syncevolution/fix-gcc6-ftbfs
Merge into: lp:~phablet-team/syncevolution/ubuntu
Diff against target: 105 lines (+72/-0)
4 files modified
debian/changelog (+10/-0)
debian/patches/0003-Add-missing-casts-from-shared_ptr-to-bool-to-fix-FTB.patch (+60/-0)
debian/patches/series (+1/-0)
debian/rules (+1/-0)
To merge this branch: bzr merge lp:~jbicha/syncevolution/fix-gcc6-ftbfs
Reviewer Review Type Date Requested Status
Ubuntu Phablet Team Pending
Review via email: mp+302980@code.launchpad.net

Description of the change

To post a comment you must log in.
4643. By Jeremy Bícha

* Add 0003-Add-missing-casts-from-shared_ptr-to-bool-to-fix-FTB.patch
  to add missing casts from shared_ptr to bool, fixes FTBFS with GCC 6
* Fix remaining FTBFS with GCC 6 by downgrading the C++ dialect to gnu++98
  (Closes: #811624) (LP: #1613405)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2016-07-06 14:15:27 +0000
+++ debian/changelog 2016-08-19 16:49:31 +0000
@@ -1,3 +1,13 @@
1syncevolution (1.5.1+16.10.20160706-0ubuntu2) yakkety; urgency=medium
2
3 [ Tino Mettler ]
4 * Add 0003-Add-missing-casts-from-shared_ptr-to-bool-to-fix-FTB.patch
5 to add missing casts from shared_ptr to bool, fixes FTBFS with GCC 6
6 * Fix remaining FTBFS with GCC 6 by downgrading the C++ dialect to gnu++98
7 (Closes: #811624) (LP: #1613405)
8
9 -- Jeremy Bicha <jbicha@ubuntu.com> Fri, 19 Aug 2016 12:48:59 -0400
10
1syncevolution (1.5.1+16.10.20160706-0ubuntu1) yakkety; urgency=medium11syncevolution (1.5.1+16.10.20160706-0ubuntu1) yakkety; urgency=medium
212
3 * New upstream release13 * New upstream release
414
=== added file 'debian/patches/0003-Add-missing-casts-from-shared_ptr-to-bool-to-fix-FTB.patch'
--- debian/patches/0003-Add-missing-casts-from-shared_ptr-to-bool-to-fix-FTB.patch 1970-01-01 00:00:00 +0000
+++ debian/patches/0003-Add-missing-casts-from-shared_ptr-to-bool-to-fix-FTB.patch 2016-08-19 16:49:31 +0000
@@ -0,0 +1,60 @@
1From 9286b8851524a85f5c9d7352f5a89c550c13f315 Mon Sep 17 00:00:00 2001
2From: Tino Mettler <tino+debian@tikei.de>
3Date: Wed, 6 Jul 2016 14:33:19 +0200
4Subject: [PATCH] Add missing casts from shared_ptr to bool to fix FTBFS with
5 GCC 6
6
7---
8 src/dbus/server/session.h | 2 +-
9 src/syncevo/Logging.h | 4 ++--
10 src/syncevo/StringDataBlob.h | 2 +-
11 3 files changed, 4 insertions(+), 4 deletions(-)
12
13diff --git a/src/dbus/server/session.h b/src/dbus/server/session.h
14index af46f5d..b762bab 100644
15--- a/src/dbus/server/session.h
16+++ b/src/dbus/server/session.h
17@@ -425,7 +425,7 @@ public:
18 void setServerAlerted(bool serverAlerted) { m_serverAlerted = serverAlerted; }
19
20 void initServer(SharedBuffer data, const std::string &messageType);
21- void setStubConnection(const boost::shared_ptr<Connection> c) { m_connection = c; m_useConnection = c; }
22+ void setStubConnection(const boost::shared_ptr<Connection> c) { m_connection = c; m_useConnection = static_cast<bool> (c); }
23 boost::weak_ptr<Connection> getStubConnection() { return m_connection; }
24 bool useStubConnection() { return m_useConnection; }
25
26diff --git a/src/syncevo/Logging.h b/src/syncevo/Logging.h
27index ce9a249..5deb01b 100644
28--- a/src/syncevo/Logging.h
29+++ b/src/syncevo/Logging.h
30@@ -255,7 +255,7 @@ class Logger
31 Handle &operator = (const Handle &other) throw ();
32 ~Handle() throw ();
33
34- operator bool () const { return m_logger; }
35+ operator bool () const { return static_cast<bool> (m_logger); }
36 bool operator == (Logger *logger) const { return m_logger.get() == logger; }
37 Logger *get() const { return m_logger.get(); }
38
39@@ -398,7 +398,7 @@ template<class L> class PushLogger : boost::noncopyable
40 }
41 }
42
43- operator bool () const { return m_logger; }
44+ operator bool () const { return static_cast<bool> (m_logger); }
45
46 void reset(const Logger::Handle &logger)
47 {
48diff --git a/src/syncevo/StringDataBlob.h b/src/syncevo/StringDataBlob.h
49index 62bc4c7..14f0d61 100644
50--- a/src/syncevo/StringDataBlob.h
51+++ b/src/syncevo/StringDataBlob.h
52@@ -53,7 +53,7 @@ class StringDataBlob : public DataBlob
53
54 virtual boost::shared_ptr<std::string> getData() { return m_data; }
55 virtual std::string getName() const { return m_name; }
56- virtual bool exists() const { return m_data; }
57+ virtual bool exists() const { return static_cast<bool> (m_data); }
58 virtual bool isReadonly() const { return m_readonly; }
59 };
60
061
=== modified file 'debian/patches/series'
--- debian/patches/series 2016-07-05 17:27:00 +0000
+++ debian/patches/series 2016-08-19 16:49:31 +0000
@@ -1,5 +1,6 @@
10001-Fix-FTBFS-on-kfreebsd-due-to-missing-SOCK_CLOEXEC.patch10001-Fix-FTBFS-on-kfreebsd-due-to-missing-SOCK_CLOEXEC.patch
20002-Avoid-register-unecessary-timezones.patch20002-Avoid-register-unecessary-timezones.patch
30003-Add-missing-casts-from-shared_ptr-to-bool-to-fix-FTB.patch
3fix-photo-merging.patch4fix-photo-merging.patch
4calendar-limit-date-sync.diff5calendar-limit-date-sync.diff
5Use-90-days-as-default-value-for-syncInterval.patch6Use-90-days-as-default-value-for-syncInterval.patch
67
=== modified file 'debian/rules'
--- debian/rules 2016-07-05 17:27:00 +0000
+++ debian/rules 2016-08-19 16:49:31 +0000
@@ -6,6 +6,7 @@
6export DH_VERBOSE=16export DH_VERBOSE=1
7export DEB_BUILD_MAINT_OPTIONS = hardening=+all7export DEB_BUILD_MAINT_OPTIONS = hardening=+all
8export DEB_CFLAGS_MAINT_APPEND = -Wall -pedantic 8export DEB_CFLAGS_MAINT_APPEND = -Wall -pedantic
9export DEB_CXXFLAGS_MAINT_APPEND = -std=gnu++98
9export DEB_LDFLAGS_MAINT_APPEND = -Wl,--as-needed10export DEB_LDFLAGS_MAINT_APPEND = -Wl,--as-needed
1011
11%: 12%:

Subscribers

People subscribed via source and target branches

to all changes: