Code review comment for lp:~jblount/libubuntuone/classy-error-pages

Revision history for this message
Rodrigo Moya (rodrigo-moya) wrote :

Ok, there are a few problems:

* in_development.html seems to be missing, right? Also, the call to load that file seems to be missing also.
* There are some leaks in the C code:

552 + calculated_file_url = g_strdup_printf("%s?%s",
553 + g_filename_to_uri(calculated_file_path, NULL, NULL),
554 + reload_url);

g_filename_to_uri returns a newly-allocated string, so you need to store it in a variable, use it to g_strdup_printf calculated_file_url, and then g_free it.

* also, we use the GNOME coding style for couchdb-glib (because it's going to be included in GNOME soon), so could you please add a space after the function name and before the '(' character?

Apart from that it looks ok, so please fix that and I'll approve it

review: Needs Fixing

« Back to merge proposal