Code review comment for lp:~jcsackett/launchpad/convert-sql-627631-storm

Revision history for this message
j.c.sackett (jcsackett) wrote :

> Product.selectBy(translations_usage=ServiceUsage.LAUNCHPAD) actually generates the SQL:
> WHERE FALSE
> since Person.translations_usage is a property object and not a storm attribute.
>
> Product.selectBy(_translations_usage=ServiceUsage.LAUNCHPAD) generates the SQL:
> WHERE Product.translations_usage = 20

I got this error in another place, didn't realize I hadn't been caught everywhere. Thanks for the note. I'll fix that.

« Back to merge proposal