Code review comment for lp:~jcsackett/launchpad/convert-sql-627631-storm

Revision history for this message
j.c.sackett (jcsackett) wrote :

> It bothers me a little bit that you will be converting queries over to _translations_usage and then back to translations_usage once the property is removed, but I guess that will be a simple search and replace, so it should be fine to land this branch now.

It bothers me a little bit too. Perhaps I misunderstood some of your earlier comments--there's a way to have the query use translations_usage rather than _translations_usage and still have it work? The validator stuff I have seen doesn't seem applicable.

« Back to merge proposal