Code review comment for lp:~jcsackett/launchpad/new-releases-636060

Revision history for this message
Graham Binns (gmb) wrote :

A few comments:

> 8 + def getLatestRelease():
> 9 + """Gets the most recent release in the series.
> 10 +
> 11 + Returns None if there is no release."""
> 12 +

The closing """ of a multi-line docstring should be on its own line.

> 89 + def setUp(self):
> 90 + super(TestProductSeriesReleases, self).setUp()
> 91 + self.product = self.factory.makeProduct()
> 92 + self.productseries = self.factory.makeProductSeries(
> 93 + product=self.product)
> 94 +
> 95 + def test_getLatestRelease(self):
> 96 + # getLatestRelease returns the most recent release.
> 97 + self.assertIs(None, self.productseries.getLatestRelease())
> 98 +
> 99 + release = self.factory.makeProductRelease(
> 100 + product=self.product,
> 101 + productseries=self.productseries)
> 102 + self.assertEqual(release, self.productseries.getLatestRelease())
> 103 +
> 104 + second_release = self.factory.makeProductRelease(
> 105 + product=self.product,
> 106 + productseries=self.productseries)

We indent parameters on method calls by four spaces, e.g.:

    second_release = self.factory.makeProductRelease(
        product=self.product, productseries=self.productseries)

review: Approve (code)

« Back to merge proposal